Skip to content

Remove non-standard 'icon' property (#7430)#7508

Merged
zpao merged 1 commit intofacebook:masterfrom
smockle:remove-html-icon-attribute
Aug 29, 2016
Merged

Remove non-standard 'icon' property (#7430)#7508
zpao merged 1 commit intofacebook:masterfrom
smockle:remove-html-icon-attribute

Conversation

@smockle
Copy link
Copy Markdown
Contributor

@smockle smockle commented Aug 15, 2016

Before submitting a pull request, please make sure the following is done...

  1. Fork the repo and create your branch from master.
  2. If you've added code that should be tested, add tests!
  3. If you've changed APIs, update the documentation.
  4. Ensure the test suite passes (grunt test).
  5. Make sure your code lints (grunt lint) - we've done our best to make sure these rules match our internal linting guidelines.
  6. If you haven't already, complete the CLA.

The above is done!

@zpao
Copy link
Copy Markdown
Member

zpao commented Aug 29, 2016

Thanks! Let's go ahead and get this in. We won't cherry-pick it over to the stable branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants